[libvirt] [PATCH 3/3] virsh: Use virNodeGetCPUMap if possible

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Wed Oct 31 17:24:29 UTC 2012


On 10/31/2012 02:30 AM, Eric Blake wrote:
>
> This looks correct.  However, it may be easier to write a helper
> function vshGetCPUCount, rather than copying and pasting this code into
> multiple places.  I'm okay giving this an ACK, but since I've already
> asked for a v2 of patch 1, you might want to do a v2 of this as well.
> Oh, and I guess the same comment applies to the python code in 2/3.
>

Thanks for the comments, I have to agree in all points.
New series underway.

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list