[libvirt] [PATCH] Check for private symbols presence as well

Eric Blake eblake at redhat.com
Fri Oct 5 13:13:12 UTC 2012


On 10/05/2012 07:05 AM, Michal Privoznik wrote:
> Currently, we are checking if libvirt.so contains public symbols.
> However, sometimes we rename an internal symbol and forget to
> change libvirt_private.syms accordingly. Hence, it's safer to check
> for internal symbols as well.
> ---
>  src/Makefile.am      |    7 ++++++-
>  src/check-symfile.pl |    2 +-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 

ACK.  I confirmed that this catches the problem fixed by your commit
fcd6477.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121005/5f151c98/attachment-0001.sig>


More information about the libvir-list mailing list