[libvirt] [PATCH 2/2] blockjob: wire up online qemu block-commit

[Kashyap Chamarthy]

On 10/06/2012 01:26 AM, Eric Blake wrote:
> On 10/05/2012 01:25 PM, Kashyap Chamarthy wrote:
>>>
>>> So, just to clarify, so I don't mess up,  on libvirt's latest git, I'm applying only these
>>> two patches as below:
>>>
>>> [PATCH 1/2] blockjob: manage qemu block-commit monitor command
>>> [PATCH 2/2] blockjob: wire up online qemu block-commit
>>>
>>> # git am -3 /path-to-patch1
>>> # git am -3 /path-to-patch2
>>> # ./autogen.sh
> 
> Here, I tend to use './autogen.sh --system CFLAGS=-g' if I intend to
> debug anything under gdb; the --system makes it more likely that the
> just-built libvirtd can be run without having to install it first.  But
> the ./run script also helps there.
> 
>>> # make
>>> # make check
>>>
>>> Then run the below (while using the qemu binary from it's git #
>>> ./x86_64-softmmu/qemu-system-x86_64 --enable-kvm -smp 2 -m 1024
>>> /home/kashyap/vmimages/f17vm2.qcow2)
>>
>> (of-course with relevant changes to the 'emulator' attribute to the domain's libvirt xml file)
> 
> Yep, and/or install the just-built qemu into the system location.
> 
>>
>>>
>>> And use the 'virsh' to do the testing from the fresh compile:
>>>
>>> # ./run ./tools/virsh ...
>>>
> 
> Yep, that's about what I'm doing in my tests.

Cool, patches applied just fine, 'make check' says all 68 tests passed. and I could just
see the help output for 'blockcommit' once I compiled the git. Will continue with real
testing tomorrow. And report results/findings in a separate thread.

(I'm not quite familiar w/ libvirt-tck framework (also, not a perl expert). I'll see if I
can write some shell/python scripts, if it's of any value.)

> 


-- 
/kashyap