[libvirt] [PATCH] conf: Fix crash with cleanup
Daniel P. Berrange
berrange at redhat.com
Tue Oct 16 09:50:21 UTC 2012
On Tue, Oct 16, 2012 at 11:19:55AM +0200, Martin Kletzander wrote:
> There was a crash possible when both <boot dev... and <boot
> order... were specified due to virDomainDefParseBootXML() erroring out
> before setting *tmp (which was free'd in cleanup). As a fix, I
> created this cleanup that uses one pointer for all the temporary
> stored XPath strings and values, plus this pointer is correctly
> initialized to NULL.
> ---
> src/conf/domain_conf.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
It would be nice to have a test to check for this scenario
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list