[libvirt] [PATCH v2] virsh: Fix segfault of snapshot-list

[Eric Blake]

On 10/22/2012 08:28 AM, Osier Yang wrote:
> 'snaps' is used after free()'ed.
> ---
>  tools/virsh-snapshot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
> index 6dd8bf2..fc6c5b3 100644
> --- a/tools/virsh-snapshot.c
> +++ b/tools/virsh-snapshot.c
> @@ -866,7 +866,7 @@ vshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
>                      goto cleanup;
>              }
>              if (from) {
> -                snaps[snaplist->nsnaps++] = from;
> +                snaplist->snaps[snaplist->nsnaps++].snap = from;

ACK.  Thanks for cleaning up my mess.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121022/4a324c74/attachment-0001.sig>