[libvirt] [PATCH v2] virsh: Fix segfault of snapshot-list
Osier Yang
jyang at redhat.com
Mon Oct 22 14:52:23 UTC 2012
On 2012年10月22日 22:46, Eric Blake wrote:
> On 10/22/2012 08:28 AM, Osier Yang wrote:
>> 'snaps' is used after free()'ed.
>> ---
>> tools/virsh-snapshot.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
>> index 6dd8bf2..fc6c5b3 100644
>> --- a/tools/virsh-snapshot.c
>> +++ b/tools/virsh-snapshot.c
>> @@ -866,7 +866,7 @@ vshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
>> goto cleanup;
>> }
>> if (from) {
>> - snaps[snaplist->nsnaps++] = from;
>> + snaplist->snaps[snaplist->nsnaps++].snap = from;
>
> ACK. Thanks for cleaning up my mess.
>
Pushed, thanks.
More information about the libvir-list
mailing list