[libvirt] [PATCHv9] snapshot: sanity check when reusing file for snapshot

Eric Blake eblake at redhat.com
Tue Oct 23 02:17:17 UTC 2012


On 10/22/2012 03:03 PM, Peter Krempa wrote:
> On 10/22/12 22:34, Eric Blake wrote:
>> The snapshot code when reusing an existing file had hard-to-read
>> logic, as well as a missing sanity check: REUSE_EXT should require
>> the destination to already be present.
>>
>> * src/qemu/qemu_driver.c (qemuDomainSnapshotDiskPrepare): Require
>> destination on REUSE_EXT, rename variable for legibility.
>> ---
>>
>> v9: separate out from larger series, as this one is ready now;
>> provide diff with more context and a renamed variable.
>> https://www.redhat.com/archives/libvir-list/2012-October/msg01107.html
>>
>>   src/qemu/qemu_driver.c | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121022/d6a60d54/attachment-0001.sig>


More information about the libvir-list mailing list