[libvirt] [PATCH] xml: omit domain name from comment if it contains double hyphen

Daniel P. Berrange berrange at redhat.com
Tue Oct 23 15:31:55 UTC 2012


On Tue, Oct 23, 2012 at 02:16:44PM +0200, Ján Tomko wrote:
> We put a comment containing "virsh edit <domain_name>" at the start of
> the XML. W3C recommendation forbids the use of "--" in comments [1] and
> libvirt can't parse it either. This patch omits the domain name if it
> contains a double hyphen.

I'd really rather that we properly escaped the data rather than
just dropping it.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list