[libvirt] [PATCH] xml: shell-escape domain name in comment

Ján Tomko jtomko at redhat.com
Wed Oct 24 13:14:31 UTC 2012


On 10/24/12 14:59, Jiri Denemark wrote:
> On Wed, Oct 24, 2012 at 14:03:12 +0200, Ján Tomko wrote:
> I should have spoken earlier but why don't we just emit UUID there? It's
> guaranteed that it is safe for both XML and shell and thus can be just
> copy&pasted even into interactive virsh.

UUIDs are uglier than plain domain names, but they might be prettier
than some escaped ones, and would work even with tcsh (which doesn't
seem to understand single quotes).

How about emiting UUID for domains containing special shell characters
or "]]>" and domain names for the rest (including "--")?




More information about the libvir-list mailing list