[libvirt] [libvirt-perl PATCH] Fix several APIs
Osier Yang
jyang at redhat.com
Mon Sep 3 10:29:47 UTC 2012
On 2012年08月29日 14:44, Daniel P. Berrange wrote:
> On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote:
>> ACK.
>>
>> --
>> Regards,
>> Alex
>>
>>
>> ----- Original Message -----
>> From: "Osier Yang"<jyang at redhat.com>
>> To: libvir-list at redhat.com
>> Sent: Tuesday, August 28, 2012 11:52:24 PM
>> Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs
>>
>> These APIs accept one more argument (flags), which was ignored in
>> the XS implementations.
>> ---
>> Virt.xs | 46 ++++++++++++++++++++++++++--------------------
>> 1 files changed, 26 insertions(+), 20 deletions(-)
>
> ACK, if you also update the Domain.pm docs to mention the new flags
> parameters
>
Thanks, Pushed with the doc and nits pointed out by gren updated
(btw, most of the flags for APIs are not documented, and even some
constants, such as constants for virTypedParameterFlags, could be
later patch).
Regards,
Osier
More information about the libvir-list
mailing list