[libvirt] [PATCH 1/4] Fix docs for PM event callbacks
Eric Blake
eblake at redhat.com
Thu Sep 6 23:48:49 UTC 2012
On 09/06/2012 05:29 PM, Doug Goldstein wrote:
> On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark <jdenemar at redhat.com> wrote:
>> PM{Suspend,Wakeup} event callbacks were designed with a reason parameter
>> which could be used in the future. However, we do not transfer the
>> reason over RPC and thus we can never use it in the future. Make it
>> explicit in the docs.
>> ---
>> include/libvirt/libvirt.h.in | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
Why can't we create a new RPC that _does_ pass reason, then when the
event fires, we call the appropriate RPC based on the capabilities of
the receiving end? That is, I don't think we are locked into never
being able to pass a useful reason.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120906/d5331c7b/attachment-0001.sig>
More information about the libvir-list
mailing list