[libvirt] [PATCHv3 0/4] Add range checking for scheduler tunables

Peter Krempa pkrempa at redhat.com
Fri Sep 7 06:22:46 UTC 2012


On 09/07/12 01:03, Eric Blake wrote:
> On 09/06/2012 08:01 AM, Peter Krempa wrote:
>> This version improves virsh so that it doesn't update all tunables
>> but only those that changed (and now correctly).
>>
>> This series contains a new patch that adds a helper to deal
>> with typed parameters.
>>
>> Regarding typed parameters: Shouldn't we make the helpers to deal
>> with them public?
>>
>> (Patches 1 and 2 didn't change to v2)
>
> Technically, the commit message of 1 changed, but for the better; and
> you folded in my LL hint in commit 2.

I noted that in v2, but that version had some trouble.

>
>>
>> Peter Krempa (4):
>>    qemu: clean up qemuSetSchedulerParametersFlags()
>>    qemu: Add range checking for scheduler tunables when changed by API
>>    util: Add helper to assign typed params from string
>>    virsh: Update only changed scheduler tunables
>
> ACK series, with nit in 3 fixed.
>

I fixed the nit and pushed the series. Thanks!

Peter





More information about the libvir-list mailing list