[libvirt] [PATCHv6 0/2] Implementation of virConnectListAllDomains() for esx and hyperv
Matthias Bolte
matthias.bolte at googlemail.com
Sun Sep 9 16:04:29 UTC 2012
2012/9/6 Peter Krempa <pkrempa at redhat.com>:
> On 09/06/12 07:24, Daniel Veillard wrote:
>>
>> On Fri, Aug 31, 2012 at 05:36:51PM +0200, Peter Krempa wrote:
>>>
>>> Yet another respin updated and rebased to current head.
>>>
>>> Both drivers are compile tested but I don't have the infrastructure do a
>>> functional test.
>>>
>>> Peter Krempa (2):
>>> hyperv: Add implementation for virConnectListAllDomains()
>>> esx: Add implementation for virConnectListAllDomains()
>>>
>>> src/esx/esx_driver.c | 194
>>> +++++++++++++++++++++++++++++++++++++++++++++
>>> src/hyperv/hyperv_driver.c | 135 +++++++++++++++++++++++++++++++
>>> 2 files changed, 329 insertions(+)
>>
>>
>> I was hoping to see feedback on actual users, but since we are at v6
>> and nobody replied, let's push them and see
>>
>> ACK,
>
>
> Yep, let's just test it in the wild :). I corrected a bug that would create
> empty lists on ESX if some filters were used that I found during a last
> self-review and pushed the series. Thanks.
And here comes your in-the-wild testing :)
Sorry for not taking care of this earlier.
Both patches look quite well, but there are some small problems and
possibilities for improvement. I've posted two patches for this:
https://www.redhat.com/archives/libvir-list/2012-September/msg00486.html
https://www.redhat.com/archives/libvir-list/2012-September/msg00485.html
The Hyper-V patch is not runtime tested yet because I currently have
some trouble getting my Hyper-V setup to work again. I'll report back
on this once I get it running.
--
Matthias Bolte
http://photron.blogspot.com
More information about the libvir-list
mailing list