[libvirt] [PATCH] python: Initialize new_params in virDomainSetSchedulerParameters
Guannan Ren
gren at redhat.com
Tue Sep 11 14:47:28 UTC 2012
On 09/11/2012 10:41 PM, Federico Simoncelli wrote:
> The new_params variable must be initialized in case the
> virDomainGetSchedulerParameters call fails and we hit the cleanup
> section before actually allocating the new parameters.
>
> Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
> ---
> python/libvirt-override.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/python/libvirt-override.c b/python/libvirt-override.c
> index bb1d881..485ed28 100644
> --- a/python/libvirt-override.c
> +++ b/python/libvirt-override.c
> @@ -700,7 +700,7 @@ libvirt_virDomainSetSchedulerParameters(PyObject *self ATTRIBUTE_UNUSED,
> int i_retval;
> int nparams = 0;
> Py_ssize_t size = 0;
> - virTypedParameterPtr params, new_params;
> + virTypedParameterPtr params, new_params = NULL;
>
> if (!PyArg_ParseTuple(args, (char *)"OO:virDomainSetScedulerParameters",
> &pyobj_domain, &info))
yes, we need initialize it.
ACK
Guannan
More information about the libvir-list
mailing list