[libvirt] [PATCH v2 1/9] fix bug in qemuSetupCgroupForEmulator

Eric Blake eblake at redhat.com
Tue Sep 11 21:39:35 UTC 2012


On 09/06/2012 10:56 PM, Eric Blake wrote:
> On 09/06/2012 04:13 AM, Hu Tao wrote:
>> Should not return 0 when failed to setup cgroup.
>> ---
>>  src/qemu/qemu_cgroup.c |    8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> ACK with one nit.
> 

>> +        if (rc < 0)
>>          goto cleanup;
> 
> Indentation is now off.

Pushed with this fixed.  Awaiting v3 for the rest of the series, but do
make sure that you are aware of the interface that Dan has proposed and
reconcile according to my suggestions:
https://www.redhat.com/archives/libvir-list/2012-September/msg00698.html

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120911/681723a5/attachment-0001.sig>


More information about the libvir-list mailing list