[libvirt] [libvirt-designer][PATCH 1/3] init_check: Ignore DB loading errors

Michal Privoznik mprivozn at redhat.com
Wed Sep 12 15:09:33 UTC 2012


Osinfo DB loader returns an error if users have a malformed XML file.
However, it doesn't affect loading of other files, so we should not
make those errors fatal. In addition, if osinfo DB is empty users
will obtain appropriate error on very next API involving querying
the DB.
---
 libvirt-designer/libvirt-designer-main.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/libvirt-designer/libvirt-designer-main.c b/libvirt-designer/libvirt-designer-main.c
index f2381a6..5c70b57 100644
--- a/libvirt-designer/libvirt-designer-main.c
+++ b/libvirt-designer/libvirt-designer-main.c
@@ -89,9 +89,7 @@ gboolean gvir_designer_init_check(int *argc,
     /* XXX maybe we want to let users tell a different path via
      * env variable or argv */
     osinfo_loader = osinfo_loader_new();
-    osinfo_loader_process_default_path(osinfo_loader, err);
-    if (err)
-        return FALSE;
+    osinfo_loader_process_default_path(osinfo_loader, NULL);
 
     osinfo_db = osinfo_loader_get_db(osinfo_loader);
 
-- 
1.7.8.6




More information about the libvir-list mailing list