[libvirt] [PATCH 7/7] list: Use virConnectListAllNodeDevices in virsh

Osier Yang jyang at redhat.com
Thu Sep 13 07:01:05 UTC 2012


On 2012年09月07日 06:05, Peter Krempa wrote:
> On 09/05/12 07:34, Osier Yang wrote:
>> tools/virsh-nodedev.c:
>> * vshNodeDeviceSorter to sort node devices by name
>>
>> * vshNodeDeviceListFree to free the node device objects list.
>>
>> * vshNodeDeviceListCollect to collect the node device objects, trying
>> to use new API first, fall back to older APIs if it's not supported.
>>
>> * Change option --cap to accept multiple capability types.
>>
>> tools/virsh.pod
>> * Update document for --cap
>> ---
>> tools/virsh-nodedev.c | 302
>> ++++++++++++++++++++++++++++++++++++++++++------
>> tools/virsh.pod | 8 +-
>> 2 files changed, 269 insertions(+), 41 deletions(-)
>>
>> diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c
>> index cd88538..2c054ea 100644
>> --- a/tools/virsh-nodedev.c
>> +++ b/tools/virsh-nodedev.c
>> @@ -36,6 +36,7 @@
>> #include "memory.h"
>> #include "util.h"
>> #include "xml.h"
>> +#include "conf/node_device_conf.h"
>
> Gah this include isn't nice :/. We probably should put the filter flags
> in a more public header file.
>

I kept this, and will clean up all the internal header including later
(including the ones before the atomic apis).

Regards,
Osier




More information about the libvir-list mailing list