[libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

[Kyle Mestery (kmestery)]

On Sep 13, 2012, at 3:09 PM, Laine Stump wrote:
> On 09/12/2012 11:08 PM, Kyle Mestery (kmestery) wrote:
>> Hi Laine:
>> 
>> I'm in the process of reworking this patch along the lines you and Daniel have
>> provided input towards. I defined some helper functions in virnetdevopenvswitch.c,
>> but when calling them from qemu_migration.c, the build is failing during linking.
>> I suspect I need to add whatever gets built out of src/util to the qemu stuff, but before
>> going down that path, wanted to run this by the list. Here is the error I see:
>> 
>> make[3]: Leaving directory `/production/git/local/libvirt/libvirt/python'
>> Making all in tests
>> make[3]: Entering directory `/production/git/local/libvirt/libvirt/python/tests'
>> make[3]: Nothing to be done for `all'.
>> make[3]: Leaving directory `/production/git/local/libvirt/libvirt/python/tests'
>> make[2]: Leaving directory `/production/git/local/libvirt/libvirt/python'
>> Making all in tests
>> make[2]: Entering directory `/production/git/local/libvirt/libvirt/tests'
>>  CCLD   qemuxml2argvtest
>> ../src/.libs/libvirt_driver_qemu_impl.a(libvirt_driver_qemu_impl_la-qemu_migration.o): In function `qemuMigrationCookieNetworkAlloc':
>> /production/git/local/libvirt/libvirt/src/qemu/qemu_migration.c:343: undefined reference to `virNetDevOpenvswitchGetMigrateData'
>> ../src/.libs/libvirt_driver_qemu_impl.a(libvirt_driver_qemu_impl_la-qemu_migration.o): In function `qemuDomainMigrateOPDRelocate':
>> /production/git/local/libvirt/libvirt/src/qemu/qemu_migration.c:1302: undefined reference to `virNetDevOpenvswitchSetMigrateData'
> 
> Usually this means that you haven't added the new utility functions to
> src/libvirt_private.syms. Find the section for the source file the new
> function was added to, then add in the name of your new function with a
> semicolon at the end of the line. Be sure to keep the names in
> alphabetic order (within each file) lest you incur the wrath of Eric! :-)
> 

Awesome, that was the issue, thanks for the help Laine!

Kyle