[libvirt] [PATCH] qemu: Transition domain to PAUSED after 'stop' command
Michal Privoznik
mprivozn at redhat.com
Wed Sep 19 09:43:02 UTC 2012
Currently, we mark domain PAUSED (but not emit an event)
just before we issue 'stop' on monitor; This command can
take ages to finish, esp. when domain's doing a lot of
IO - users can enforce qemu to open files with O_DIRECT
which doesn't return from write() until data reaches the
block device. Having said that, we report PAUSED even if
domain is not paused yet.
---
The event is emitted correctly after all operations returns though.
But if mgmt app would 'virsh domstate $dom' as we are issuing 'stop'
monitor command it could get spurious results.
src/qemu/qemu_process.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index c28f5a5..b6eb342 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2708,13 +2708,9 @@ int qemuProcessStopCPUs(struct qemud_driver *driver, virDomainObjPtr vm,
enum qemuDomainAsyncJob asyncJob)
{
int ret;
- int oldState;
- int oldReason;
qemuDomainObjPrivatePtr priv = vm->privateData;
VIR_FREE(priv->lockState);
- oldState = virDomainObjGetState(vm, &oldReason);
- virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, reason);
ret = qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob);
if (ret == 0) {
@@ -2723,11 +2719,10 @@ int qemuProcessStopCPUs(struct qemud_driver *driver, virDomainObjPtr vm,
}
if (ret == 0) {
+ virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, reason);
if (virDomainLockProcessPause(driver->lockManager, vm, &priv->lockState) < 0)
VIR_WARN("Unable to release lease on %s", vm->def->name);
VIR_DEBUG("Preserving lock state '%s'", NULLSTR(priv->lockState));
- } else {
- virDomainObjSetState(vm, oldState, oldReason);
}
return ret;
--
1.7.8.6
More information about the libvir-list
mailing list