[libvirt] Two core dumps are generated in multi-thread scenarios

[Benjamin Wang (gendwang)]

Hi,
  Old code(in esx_vi.c) is as below:
curl_easy_setopt(curl->handle, CURLOPT_USERAGENT, "libvirt-esx");
curl_easy_setopt(curl->handle, CURLOPT_HEADER, 0);

New code:
curl_easy_setopt(curl->handle, CURLOPT_NOSIGNAL, 1);
curl_easy_setopt(curl->handle, CURLOPT_USERAGENT, "libvirt-esx");
curl_easy_setopt(curl->handle, CURLOPT_HEADER, 0);

B.R.
Benjamin Wang

-----Original Message-----
From: Daniel Veillard [mailto:veillard at redhat.com] 
Sent: 2012年9月23日 16:52
To: Benjamin Wang (gendwang)
Cc: Matthias Bolte; libvir-list at redhat.com; Yang Zhou (yangzho)
Subject: Re: [libvirt] Two core dumps are generated in multi-thread scenarios

On Sun, Sep 23, 2012 at 03:32:52AM +0000, Benjamin Wang (gendwang) wrote:
> Hi,
>   I found two core dumps generated in multi-thread scenarios in ESX part.
> Case1: libcurl support multi-thread
> core dump:
> #12 0x00002aaabea89712 in addbyter () from /usr/local/lib/libcurl.so.4
> #13 0x00002aaabea89b86 in dprintf_formatf () from 
> /usr/local/lib/libcurl.so.4
> #14 0x00002aaabea8b055 in curl_mvsnprintf () from 
> /usr/local/lib/libcurl.so.4
> #15 0x00002aaabea7678f in Curl_failf () from 
> /usr/local/lib/libcurl.so.4
> #16 0x00002aaabea6d871 in Curl_resolv_timeout () from 
> /usr/local/lib/libcurl.so.4
> #17 0x00000006e8a8f230 in ?? ()
> 
> Fix code:
> esxVI_CURL_Connect() in esx_vi.c:
> I add a new line as following:
> curl_easy_setopt(curl->handle, CURLOPT_NOSIGNAL, 1);

 Where exactly in the function ? Can you send a diff of your change ?

Daniel



-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library  http://libvirt.org/