[libvirt] [PATCH] build: fix detection of netcf linked with libnl1
Christophe Fergeau
cfergeau at redhat.com
Mon Sep 24 12:11:48 UTC 2012
Ping ?
Christophe
On Wed, Sep 19, 2012 at 05:08:08PM +0200, Christophe Fergeau wrote:
> Commit 9298bfbcb introduced code to detect if netcf is linked with
> libnl1, and to prefer libnl1 over libnl3 when this is the case.
> This behaviour can be disabled by setting LIBNL_CFLAGS to any value,
> including the empty string.
> However, configure.ac sets LIBNL_CFLAGS to "" before attempting
> libnl detection, so the libnl1 detection code is always disabled.
> This caused issues on my f17 system where netcf is linked with libnl1
> but libvirt got built with libnl3.
>
> This commit removes the setting of the LIBNL_* variables to "" as
> this does not appear to be needed. After this change, libnl1 is
> used when building libvirt on my f17 system.
> ---
> configure.ac | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3e90672..2cedc3f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2925,10 +2925,6 @@ AM_CONDITIONAL([WITH_VIRTUALPORT], [test "$with_virtualport" = "yes"])
>
> dnl netlink library
>
> -LIBNL_ROUTE3_CFLAGS=""
> -LIBNL_ROUTE3_LIBS=""
> -LIBNL_CFLAGS=""
> -LIBNL_LIBS=""
> have_libnl=no
>
> if test "$with_linux" = "yes"; then
> --
> 1.7.11.4
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120924/5a3eda14/attachment-0001.sig>
More information about the libvir-list
mailing list