[libvirt] [PATCHv2] qemu: Avoid holding the driver lock in trivial snapshot API's

Peter Krempa pkrempa at redhat.com
Tue Sep 25 15:12:21 UTC 2012


On 09/25/12 13:44, Michal Privoznik wrote:
> On 24.09.2012 22:45, Peter Krempa wrote:
>> In most of the snapshot API's there's no need to hold the driver lock
>> the whole time.
>>
>> This patch adds helper functions that get the domain object in functions
>> that don't require the driver lock and simplifies call paths from
>> snapshot-related API's.
>> ---
>> Diff to v1:
>> - remove touching domain configuration locking to handle NULL gracefully and
>> apropriate tweaks not to break code
>>
>>   src/qemu/qemu_driver.c | 267 +++++++++++++++----------------------------------
>>   1 file changed, 79 insertions(+), 188 deletions(-)
>
> ACK
>

Thanks; I fixed one missing leftover removal of the unlock condition, 
tweaked the comments a little bit and pushed.

Peter




More information about the libvir-list mailing list