[libvirt] [PATCH v3 03/20] Remove probing of flags when launching QEMU guests
Eric Blake
eblake at redhat.com
Wed Sep 26 00:05:06 UTC 2012
On 09/25/2012 11:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Remove all use of the existing APIs for querying QEMU
> capability flags. Instead obtain a qemuCapsPtr object
> from the global cache. This avoids the execution of
> 'qemu -help' (and related commands) when launching new
> guests.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/qemu/qemu_capabilities.c | 92 ++++----------------------------------------
> src/qemu/qemu_capabilities.h | 11 ++----
> src/qemu/qemu_command.c | 85 +++++++++-------------------------------
> src/qemu/qemu_command.h | 3 +-
> src/qemu/qemu_driver.c | 63 +++++++++++++++++++++---------
> src/qemu/qemu_process.c | 21 +++-------
> tests/qemuxml2argvtest.c | 4 --
> tests/qemuxmlnstest.c | 4 --
> 8 files changed, 81 insertions(+), 202 deletions(-)
Another nice code reduction.
ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120925/ea715820/attachment-0001.sig>
More information about the libvir-list
mailing list