[libvirt] [PATCH 3/4] parallels: remove unneded code from parallelsDoCmdRun
Daniel P. Berrange
berrange at redhat.com
Wed Sep 26 12:33:53 UTC 2012
On Wed, Sep 26, 2012 at 04:30:01PM +0400, Dmitry Guryanov wrote:
> scmd was used for debugging and I forgot to remove it before
> commit, so remove it now.
>
> Signed-off-by: Dmitry Guryanov <dguryanov at parallels.com>
> ---
> src/parallels/parallels_utils.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/src/parallels/parallels_utils.c b/src/parallels/parallels_utils.c
> index 89a0d89..521fd97 100644
> --- a/src/parallels/parallels_utils.c
> +++ b/src/parallels/parallels_utils.c
> @@ -37,23 +37,17 @@ static int
> parallelsDoCmdRun(char **outbuf, const char *binary, va_list list)
> {
> virCommandPtr cmd = virCommandNewVAList(binary, list);
> - char *scmd = NULL;
> int ret = -1;
>
> if (outbuf)
> virCommandSetOutputBuffer(cmd, outbuf);
>
> - scmd = virCommandToString(cmd);
> - if (!scmd)
> - goto cleanup;
> -
> if (virCommandRun(cmd, NULL))
> goto cleanup;
>
> ret = 0;
>
> cleanup:
> - VIR_FREE(scmd);
> virCommandFree(cmd);
> if (ret && outbuf)
> VIR_FREE(*outbuf);
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list