[libvirt] [PATCH] Fix potential deadlock when agent is closed
Eric Blake
eblake at redhat.com
Wed Sep 26 15:48:39 UTC 2012
On 09/26/2012 09:25 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> If the qemuAgentClose method is called from a place which holds
> the domain lock, it is theoretically possible to get a deadlock
> in the agent destroy callback. This has not ben observed, but
s/ben/been/
> the equivalent code in the QEMU monitor destroy callback has seen
> a deadlock.
>
> Remove the redundant locking while unrefing the object and the
> bogus assignment
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/qemu/qemu_process.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
ACK.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120926/7761d898/attachment-0001.sig>
More information about the libvir-list
mailing list