[libvirt] [libvirt-glib] build: Replace obsolete macro in configure.ac
Zeeshan Ali (Khattak)
zeeshanak at gnome.org
Tue Apr 2 15:46:46 UTC 2013
On Fri, Mar 29, 2013 at 2:49 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Fri, Mar 29, 2013 at 10:41:36AM +0100, Christophe Fergeau wrote:
>> On Fri, Mar 29, 2013 at 09:34:51AM +0100, Christophe Fergeau wrote:
>> > From: Stefano Facchini <stefano.facchini at gmail.com>
>> > diff --git a/configure.ac b/configure.ac
>> > index 96dbf5a..2bf9c1b 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -1,7 +1,7 @@
>> > AC_INIT(libvirt-glib, 0.1.7)
>> > AC_CONFIG_SRCDIR(libvirt-glib/libvirt-glib-main.c)
>> > AC_CONFIG_AUX_DIR([build-aux])
>> > -AM_CONFIG_HEADER(config.h)
>> > +AC_CONFIG_HEADERS(config.h)
>> > AC_CONFIG_MACRO_DIR([m4])
>> > dnl Make automake keep quiet about wildcards & other GNUmake-isms
>> > AM_INIT_AUTOMAKE([-Wno-portability])
>>
>> ACK from me, though I'll wait a bit before pushing in case there are some
>> autoconf/automake subtleties I'm not aware of at play here :)
>
> Actually I'd tend to squash this in:
> -AC_CONFIG_HEADERS(config.h)
> +AC_CONFIG_HEADERS([config.h])
Sure. If you have tested this to work, ACK.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
More information about the libvir-list
mailing list