[libvirt] [PATCH 16/16] Add cehck for execute command, since it will only work in lxc containers
Daniel P. Berrange
berrange at redhat.com
Wed Apr 3 11:34:52 UTC 2013
On Tue, Apr 02, 2013 at 06:11:32PM -0400, Dan Walsh wrote:
Typo in commit message & it is also too long.
> ---
> bin/virt-sandbox-service | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
> index 1cce6a5..fe659e2 100755
> --- a/bin/virt-sandbox-service
> +++ b/bin/virt-sandbox-service
> @@ -971,6 +971,9 @@ def fullpath(cmd):
> return cmd
>
> def execute(args):
> + if args.uri != "lxc:///":
> + raise ValueError(_("Can only execute commands inside of linux containers."))
> +
> myexec = [ "virsh", "-c", args.uri, "lxc-enter-namespace" ]
> # myexec = [ "virt-sandbox-service-util", "execute" ]
> if args.noseclabel:
> @@ -1120,7 +1123,7 @@ def gen_connect_args(subparser):
>
> def gen_execute_args(subparser):
> parser = subparser.add_parser("execute",
> - help=_("Execute a command within a sandbox container"))
> + help=_("Execute a command within a sandbox container. Only available for lxc:///"))
ACK if commit message is fixed
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list