[libvirt] [PATCH 1/3] Remove support for old kernels lacking private devpts

Eric Blake eblake at redhat.com
Wed Apr 3 17:33:02 UTC 2013


On 04/03/2013 11:12 AM, Daniel P. Berrange wrote:
>> We already reject compilation of LXC on RHEL 5 due to other
>> configure-time checks; is this something worth turning into an
>> additional configure test of whether a kernel is new enough, or are we
>> okay with just leaving it as a runtime test?
> 
> We can't ever check kernels during configure time, because you can't
> assume the build kernel matches the distro kernel. eg all Fedora builds
> are done in a host with a RHEL kernel

configure-time tests for an added constant that affect whether
compilation works are okay; but I can live with the fact that
improvements that aren't detected by the compiler aren't worth
hard-coding into a configure-time test (that is, runtime behavior of the
kernel running configure is not necessarily a good indicator; only
compile-time behavior is useful).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130403/f71239ee/attachment-0001.sig>


More information about the libvir-list mailing list