[libvirt] [PATCH] Wire up sysinfo for LXC driver

Eric Blake eblake at redhat.com
Wed Apr 3 20:07:44 UTC 2013


On 04/03/2013 11:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The sysinfo code used by QEMU is trivially portable to the
> LXC driver
> ---
>  src/lxc/lxc_conf.h   |  3 +++
>  src/lxc/lxc_driver.c | 29 +++++++++++++++++++++++++++++
>  2 files changed, 32 insertions(+)

ACK.


> +
> +    if (virSysinfoFormat(&buf, driver->hostsysinfo) < 0)
> +        return NULL;
> +    if (virBufferError(&buf)) {
> +        virReportOOMError();

Looks like virBufferError() in another one of those functions like
VIR_ALLOC and VIR_STRDUP where we ought to factor error handling into
the common function, and add a quiet variant for the outliers - but
that's for Michal to worry about in his series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130403/f8fec171/attachment-0001.sig>


More information about the libvir-list mailing list