[libvirt] [PATCH 2/8] Introduce new XMLs to specify disk source using libvirt storage

[Paolo Bonzini]

Il 04/04/2013 21:37, Osier Yang ha scritto:
> With this patch, one can specify the disk source using libvirt
> storage like:
> 
>   <disk type='volume' device='disk'>
>     <driver name='qemu' type='raw' cache='none'/>
>     <source pool='default' volume='fc18.img'/>
>     <target dev='vdb' bus='virtio'/>
>   </disk>
> 
> "seclables" and "startupPolicy" are not supported for this new
> disk type ("volume"). They will be supported in later patches.

Depending on the pool type, this should be treated as file or block.
You do this correctly in patch 8, but I think it is not complete.  For
example, will your patches allow SCSI passthrough of a volume inside an
iSCSI pool?

Perhaps libvirt should always work in terms of enum virStorageVolType,
initializing it from either the pool or the "type" attribute.

Paolo