[libvirt] [PATCH v4 11/11] Add test case for TPM passthrough
Daniel P. Berrange
berrange at redhat.com
Fri Apr 12 08:47:17 UTC 2013
On Thu, Apr 11, 2013 at 01:24:21PM -0400, Stefan Berger wrote:
> On 04/11/2013 11:43 AM, Daniel P. Berrange wrote:
> >On Fri, Apr 05, 2013 at 10:06:02AM -0400, Stefan Berger wrote:
> >>Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
> >>Reviewed-by: Corey Bryant <coreyb at linux.vnet.ibm.com>
> >>Tested-by: Corey Bryant <coreyb at linux.vnet.ibm.com>
> >>
> >>---
> >> tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.args | 6 +++
> >> tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.xml | 29 +++++++++++++++
> >> tests/qemuxml2argvtest.c | 3 +
> >> tests/qemuxml2xmltest.c | 2 +
> >> 4 files changed, 40 insertions(+)
> >Since you implemented support for parsing -tpmdev args, you should
> >also add to tests/qemuargv2xmltest.c - the same data files can be
> >used for all 3 testcases.
>
> Ok, so this creates quite some problems to have an XML generated
> that one doesn't have to edit afterwards, which I suppose is not
> expect. Should I just drop the parser code ?
I'm not sure I understand what your problem is ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list