[libvirt] [PATCH v2 2/2] qemu: report an error if memballoon has wrong address type

Ján Tomko jtomko at redhat.com
Tue Apr 30 08:27:43 UTC 2013


On 04/30/2013 12:14 AM, Eric Blake wrote:
> On 04/29/2013 12:20 PM, Ján Tomko wrote:
>> qemuBuildMemballoonDevStr returns NULL if memballoon doesn't have
>> the right address type, but it doesn't report an error, leading to:
>> error: An error occurred, but the cause is unknown
>>
>> Report a helpful error message instead, e.g.:
>> error: XML error: memballoon unsupported with address type 'usb'
>> ---
>>  src/qemu/qemu_command.c | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> ACK.  Both worth including in 1.0.5
> 

Thanks, both pushed now.

Jan




More information about the libvir-list mailing list