[libvirt] [PATCH 2/8] Introduce new XMLs to specify disk source using libvirt storage

[Osier Yang]

On 05/04/13 03:15, Paolo Bonzini wrote:
> Il 04/04/2013 21:37, Osier Yang ha scritto:
>> With this patch, one can specify the disk source using libvirt
>> storage like:
>>
>>    <disk type='volume' device='disk'>
>>      <driver name='qemu' type='raw' cache='none'/>
>>      <source pool='default' volume='fc18.img'/>
>>      <target dev='vdb' bus='virtio'/>
>>    </disk>
>>
>> "seclables" and "startupPolicy" are not supported for this new
>> disk type ("volume"). They will be supported in later patches.
> Depending on the pool type, this should be treated as file or block.
> You do this correctly in patch 8, but I think it is not complete.  For
> example, will your patches allow SCSI passthrough of a volume inside an
> iSCSI pool?

No, it will be another patch set. On top of Han cheng's patches.
I'm waiting for those patches go in first, or I will rebase/update
it if Han doesn't have enough time to do it, and do the work
after that.

>
> Perhaps libvirt should always work in terms of enum virStorageVolType,
> initializing it from either the pool or the "type" attribute.
>
> Paolo