[libvirt] [PATCH 1/1][RESEND] Set legacy USB option with default for ppc64.

Li Zhang zhlcindy at gmail.com
Sun Apr 7 09:00:06 UTC 2013


On 2013年03月14日 14:54, Li Zhang wrote:
> From: Li Zhang <zhlcindy at linux.vnet.ibm.com>
>
> Currently, -device xxx still can't work well for ppc64 platform.
> It's better use legacy USB option with default for ppc64.
>
> This patch is to legacy USB option with default for ppc64.
>
> Signed-off-by: Li Zhang <zhlcindy at linux.vnet.ibm.com>
> ---
>   src/qemu/qemu_command.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 1c9bfc9..618dfb1 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -5783,7 +5783,8 @@ qemuBuildCommandLine(virConnectPtr conn,
>                       }
>                   } else if (cont->type == VIR_DOMAIN_CONTROLLER_TYPE_USB &&
>                              cont->model == -1 &&
> -                           !virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI)) {
> +                           (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI) ||
> +                            def->os.arch == VIR_ARCH_PPC64)) {
>                       if (usblegacy) {
>                           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                                          _("Multiple legacy USB controllers are "
Hi Daniel,

What about this patch?

I think it's better to use legacy USB on PPC64 platform as default.
Otherwise, it still needs to add default USB mouse and keyboard when 
graphic is enabled.

Thanks. :)
--Li




More information about the libvir-list mailing list