[libvirt] [PATCH RESENT 01/12] libxl: allow script for any network interface, not only bridge

Marek Marczykowski marmarek at invisiblethingslab.com
Wed Apr 10 02:44:43 UTC 2013


This can be useful for route or NAT networks, or any other custom
network setup. Especially configuration example in documentation uses
<script/> tag with type 'ethernet'.
---
 src/libxl/libxl_conf.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index b208dd8..ffc7bbb 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -608,18 +608,11 @@ libxlMakeNic(virDomainNetDefPtr l_nic, libxl_device_nic *x_nic)
             virReportOOMError();
             return -1;
         }
-        if (l_nic->script &&
-            (x_nic->script = strdup(l_nic->script)) == NULL) {
-            virReportOOMError();
-            return -1;
-        }
-    } else {
-        if (l_nic->script) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("scripts are not supported on interfaces of type %s"),
-                           virDomainNetTypeToString(l_nic->type));
-            return -1;
-        }
+    }
+    if (l_nic->script &&
+        (x_nic->script = strdup(l_nic->script)) == NULL) {
+        virReportOOMError();
+        return -1;
     }
 
     return 0;
-- 
1.8.1.4





More information about the libvir-list mailing list