[libvirt] [PATCH v6 00/11] Add support for guests with TPM passthrough device

[Stefan Berger]

On 04/12/2013 09:37 AM, Daniel P. Berrange wrote:
> On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote:
>> Hello!
>>
>> The following set of patches adds support to libvirt for
>> adding a TPM passthrough device to a QEMU guest. Support for
>> this was recently accepted into QEMU.
>>
>> This set of patches borrows a lot from the recently added support
>> for rng's.
>>
>> Regards,
>>      Stefan
>>
>> ---
>> v5->v6:
>>    - followed tree to 039a3283
>>    - simplified virTPMFindCancelPath in 4/11 following D. Berrange's comments
> ACK to all patches in v6.
Argh, after removing the cancel_path from the virDomainTPMDef structure 
and now determining the cancel_path at the places where it is needed and 
verifying that the file actually exists, the test case only works if the 
device actually exists since it runs through that code when creating the 
QEMU command line... The idea is to SELinux label the device it in 
libvirt, which is a 'must', and pass that same file that was labeled via 
QEMU command line for QEMU to just use it. QEMU, however, can determine 
this file itself also -- though I should simplify the code there as 
well. I thought it was better to not assume the two are in lock-step, 
i.e., can find the same file, but let libvirt pass the file that was 
determined.

What do you suggest?

    Stefan