[libvirt] [PATCH] Switch to a more extensible annotation system for RPC protocols
Daniel P. Berrange
berrange at redhat.com
Wed Apr 17 15:50:33 UTC 2013
On Wed, Apr 17, 2013 at 04:43:43PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Currently the RPC protocol files can contain annotations after
> the protocol enum eg
>
> REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, /* autogen autogen priority:high */
>
> This is not very extensible as the number of annotations grows.
> Change it to use
>
> /**
> * @generate: both
> * @priority: high
> */
> REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247,
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/locking/lock_protocol.x | 68 +-
> src/remote/lxc_protocol.x | 39 +-
> src/remote/qemu_protocol.x | 51 +-
> src/remote/remote_protocol.x | 1832 +++++++++++++++++++++++++++++++++---------
> src/rpc/gendispatch.pl | 67 +-
> 5 files changed, 1638 insertions(+), 419 deletions(-)
FYI, I did not edit the .x files manually for this - aside from the
descriptive documentation comment.
The actual re-write of the annotations was automated with the attached
script.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: convert.pl
Type: application/x-perl
Size: 1238 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130417/6297c1e0/attachment-0001.pl>
More information about the libvir-list
mailing list