[libvirt] [PATCH 2/3] qemuagenttest: Check invalid response in shutdown test

Peter Krempa pkrempa at redhat.com
Fri Aug 2 08:43:20 UTC 2013


On 08/01/13 20:01, Eric Blake wrote:
> On 08/01/2013 11:57 AM, John Ferlan wrote:
>> On 08/01/2013 10:39 AM, Peter Krempa wrote:
>>> The shutdown test utilizes waiting for condition to exit the test. This
>>> addition will return an error for the shutdown command to see if the
>>> condition waiting code will not hang.
>>> ---
>>>   tests/qemuagenttest.c | 23 +++++++++++++++++++++++
>>>   1 file changed, 23 insertions(+)
>>>
>> ACK  (although running with VIR_TEST_DEBUG=1 results in a message being
>> printed which threw me at first).
>
> Do we need to call a reset function to clear the expected error?
>

This will probably warrant a separate refactor of the tests. There are a 
few of those that already report an (expected) error and then end 
successfully.

Peter




More information about the libvir-list mailing list