[libvirt] Updated patch for virt-login-shell for joing libvirt lxc containers.
Daniel P. Berrange
berrange at redhat.com
Fri Aug 2 15:52:52 UTC 2013
On Fri, Aug 02, 2013 at 11:22:07AM -0400, Daniel J Walsh wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> THis patch fixes all of Eric's and Daniels comments.
>
> [PATCH] virt-login-shell joins users into lxc container.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlH7zp8ACgkQrlYvE4MpobNx3gCbBtxw7T4fzIfHSyEEKKyjojXR
> BUUAoOToptiTOi+RC6Bdcp+zvg/xzfRh
> =7zpw
> -----END PGP SIGNATURE-----
> >From 01c7ab48e720f34c2aa891a8fa07812b1c66c316 Mon Sep 17 00:00:00 2001
> From: Dan Walsh <dwalsh at redhat.com>
> Date: Fri, 28 Jun 2013 13:50:58 -0400
> Subject: [PATCH] virt-login-shell joins users into lxc container.
>
> Openshift wants to have their gears stuck into a container when they login
> to the system. virt-login-shell will join a running gear with the username of
> the person running it, or attempt to start the container if it is not running.
> (Currently containers do not exist if they are not running, so I can not test
> this feature. But the code is there).
>
> This tool needs to be setuid since joining a container (nsjoin) requires privs.
> The root user is not allowed to execute this command. When this tool is
> run by a normal user it will only join the "users" container.
>
> Only users who are listed as valid_users in /etc/libvirt/virt-login-shell.conf
> are allowed to join containers using this tool. By default no users are allowed.
> ---
> .gitignore | 1 +
> libvirt.spec.in | 3 +
> po/POTFILES.in | 1 +
> tools/Makefile.am | 30 +++-
> tools/virt-login-shell.c | 350 ++++++++++++++++++++++++++++++++++++++++++++
> tools/virt-login-shell.conf | 26 ++++
> tools/virt-login-shell.pod | 62 ++++++++
> 7 files changed, 472 insertions(+), 1 deletion(-)
> create mode 100644 tools/virt-login-shell.c
> create mode 100644 tools/virt-login-shell.conf
> create mode 100644 tools/virt-login-shell.pod
ACK,
looks good to me now.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list