[libvirt] [PATCH] Fix double-free and broken logic in virt-login-shell

Eric Blake eblake at redhat.com
Fri Aug 9 12:27:36 UTC 2013


On 08/09/2013 05:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The virLoginShellAllowedUser method must not free the 'groups'
> parameter it is given, as that is owned by the caller.
> 
> The virLoginShellAllowedUser method should be checking
> '!*ptr' (ie empty string) rather than '!ptr' (NULL string)
> since the latter cannot be true.

This only fixes the blatant errors that I called out, but there are
still more (cosmetic) fixes needed:
https://www.redhat.com/archives/libvir-list/2013-August/msg00398.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130809/1aafdd5c/attachment-0001.sig>


More information about the libvir-list mailing list