[libvirt] [PATCH] libxl: Create per-domain log file

[Daniel P. Berrange]

On Fri, Aug 09, 2013 at 10:48:52AM -0600, Jim Fehlig wrote:
> Daniel P. Berrange wrote:
> > On Thu, Aug 08, 2013 at 05:41:26PM -0600, Jim Fehlig wrote:
> >   
> >> Currently, only one log file is created by the libxl driver, with
> >> all output from libxl for all domains going to this one file.
> >>
> >> Create a per-domain log file based on domain name, making sifting
> >> through the logs a bit easier.  This required deferring libxl_ctx
> >> allocation until starting the domain, which is fine since the
> >> ctx is not used when the domain is inactive.
> >> ---
> >>  src/libxl/libxl_conf.h   |  5 +--
> >>  src/libxl/libxl_driver.c | 88 +++++++++++++++++++++++++++++-------------------
> >>  2 files changed, 57 insertions(+), 36 deletions(-)
> >>     
> >
> > Startup of libvirtd SEGVs with this change in GIT
> >
> > ==4706== For counts of detected and suppressed errors, rerun with: -v
> > ==4706== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
> > ==4601== Thread 12:
> > ==4601== Invalid read of size 8
> > ==4601==    at 0x1E57964F: xtl_logv (in /usr/lib64/libxenctrl.so.4.2.0)
> > ==4601==    by 0x1E5796D3: xtl_log (in /usr/lib64/libxenctrl.so.4.2.0)
> > ==4601==    by 0x1E33258A: ??? (in /usr/lib64/libxenlight.so.2.0.0)
> > ==4601==    by 0x1E332641: ??? (in /usr/lib64/libxenlight.so.2.0.0)
> > ==4601==    by 0x1E317CD7: libxl_ctx_alloc (in /usr/lib64/libxenlight.so.2.0.0)
> >   
> 
> I should have looked at the xen code closer.  Seems libxl doesn't cope
> well with a NULL logger :(.
> 
> Hmm, should the logger for this driver-wide ctx (used for getting libxl
> version and the like, no domain ops) just dump messages to /dev/null or
> should they go to a driver-wide log file?

Depends if you think there's any useful info to be had from the
driver wide context object ? If so, then probably best to have a
driver-wide log file for those messages


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|