[libvirt] [PATCH] maint: avoid C99 loop declaration

Guido Günther agx at sigxcpu.org
Sat Aug 10 07:48:35 UTC 2013


Hi Eric,
On Thu, Aug 08, 2013 at 02:28:19PM -0600, Eric Blake wrote:
> On 08/08/2013 12:41 PM, Guido Günther wrote:
> > On Wed, Aug 07, 2013 at 04:53:30PM -0600, Eric Blake wrote:
> >> Commit 3d0e3c1 reintroduced a problem previously squelched in
> >> commit 7e5aa78.  Add a syntax check this time around.
> > 
> > Didn't notice we want to avoid this sorry.
> 
> That's okay - it's my own fault for not adding a syntax-check last time
> it happened.  Eventually, we will reach a day where we quit catering to
> RHEL 5's ancient gcc as our minimum version, but at least now we can
> detect the problem without having to resort to waiting for someone to
> actually test the build on RHEL 5...
>
> Maybe it's worth someone trying to set up an autobuilder on a RHEL 5 VM?
>  (My own RHEL 5 setup is too sporadic, on only once a month or so,
> mainly for my own regression testing).

I was hoping to add more distros to the libvirt jenkins [1] builds but
am currently struggling at keeping the existent ones in shape. (Some of
them are run on an irregular basis on a different machine to safe some
power). I'll add RHEL5 to my todo list.

Cheers,
 -- Guido

[1] http://honk.sigxcpu.org:8001/view/libvirt/




More information about the libvir-list mailing list