[libvirt] [PATCH 0/2] Support setting the 'removable' flag for USB disks

Fred A. Kemp anonym at riseup.net
Tue Aug 13 11:52:32 UTC 2013


From: "Fred A. Kemp" <anonym at riseup.net>

The commit message of patch #2 explains the purpose of this patch set.
A review would be greatly appreciated!

Note that I've only added the new capability for usb-storage.removable
to the qemu help tests of qemu(-kvm) version 1.2.0, since that's what I
had easily available to get the output of `-device usb-storage,?` from.
I hope that's not an issue, otherwise, is there a way to obtain these
outputs without having to hunt down and install all supported versions?

Previous submissions of this patch set to this list:
http://www.redhat.com/archives/libvir-list/2013-March/msg01051.html
http://www.redhat.com/archives/libvir-list/2013-May/msg02039.html
https://www.redhat.com/archives/libvir-list/2013-July/msg01635.html

Fred A. Kemp (2):
  qemu: Add capability flag for usb-storage
  qemu: Support setting the 'removable' flag for USB disks

 docs/formatdomain.html.in                          |    8 +++--
 docs/schemas/domaincommon.rng                      |    8 +++++
 src/conf/domain_conf.c                             |   31 ++++++++++++++++++--
 src/conf/domain_conf.h                             |    1 +
 src/qemu/qemu_capabilities.c                       |   10 +++++++
 src/qemu/qemu_capabilities.h                       |    2 ++
 src/qemu/qemu_command.c                            |   23 +++++++++++++--
 tests/qemuhelpdata/qemu-1.2.0-device               |   11 +++++++
 tests/qemuhelpdata/qemu-kvm-1.2.0-device           |   11 +++++++
 tests/qemuhelptest.c                               |   20 +++++++++----
 .../qemuxml2argv-disk-usb-device-removable.args    |    8 +++++
 .../qemuxml2argv-disk-usb-device-removable.xml     |   27 +++++++++++++++++
 tests/qemuxml2argvtest.c                           |    6 +++-
 13 files changed, 151 insertions(+), 15 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb-device-removable.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb-device-removable.xml

-- 
1.7.10.4




More information about the libvir-list mailing list