[libvirt] [PATCH glib] Remove dead cleanup code in object fetch_list helpers

Christophe Fergeau cfergeau at redhat.com
Mon Aug 19 09:43:34 UTC 2013


Hey,

On Thu, Aug 15, 2013 at 01:41:44PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The fetch_list helper cleanup code iterates over the
> elements in 'lst' array free'ing each one. This is dead
> code, however, since the only way to get there is from
> codepaths which do not populate 'lst' elements.

ACK. Calling g_free on libvirt-allocated memory was also not very good, so
good to have this gone.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130819/44faead6/attachment-0001.sig>


More information about the libvir-list mailing list