[libvirt] virtlockd max_clients limitation

[Daniel P. Berrange]

On Sun, Aug 18, 2013 at 02:46:54PM +0000, David Weber wrote:
> Hi,
> 
> we recently ran into a problem when trying to start more than 20 guests if 
> direct locking with virtlockd was enabled. The error message locked like this:
> # start test7
> error: Failed to start domain test7
> error: Cannot recv data: Connection reset by peer
> 
> Our research indicated there is a max_clients parameter set in src/locking/lock_daemon.c which causes the limitation.
> Simply increasing this number works as a workaround.
> 
> I don't have a deep understanding of the code, so I don't know if there is a 
> bug and the connection should be dropped after the lock is set or if 
> max_clients really is the way to go. If the latter I guess max_clients should 
> be configurable like in virtlockd or at least be higher than 20 :)

Yikes, that was a stupid hardcoded limt on my part !

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|