[libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option

Eric Blake eblake at redhat.com
Tue Aug 20 02:28:57 UTC 2013


On 08/19/2013 08:01 PM, Guan Nan Ren wrote:
> 
> 
> ----- Original Message -----
> From: "Eric Blake" <eblake at redhat.com>
> To: libvir-list at redhat.com
> Sent: Monday, August 19, 2013 6:43:15 PM
> Subject: [libvirt] [PATCH 3/3] virt-pki-validate: add --help/--version option
> 
> Another program gains --help/--version :)
> 

> +
> +case $1 in
> +case $1 in
> 
> copy-paste error, double case lines.

Oops - must have hit send before my final save.  Thanks for catching that.

> 
> 
> +  -h | --h | --he | --hel | --help)
> +    cat <<EOF
> ...
> 
> +
> +if test $# != 0; then
> +    echo "$0: unrecognized argument '$1'" >&2
> +    exit 1 ;;
> 
> remove ;; here.
> 
> 
> ACK with these small fixes.

After one more round of testing, I pushed the fixed patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130819/4d51dc33/attachment-0001.sig>


More information about the libvir-list mailing list