[libvirt] [PATCHv2 2/3] virsh-pool: Improve error message in cmdPoolList

Peter Krempa pkrempa at redhat.com
Tue Aug 20 14:15:45 UTC 2013


Explicitly let the user know about the unknown pool type.
---

Notes:
    Version 2:
    * fixed commit message
    * ACK'd in v1 (would cause conflict if reordering ...)

 tools/virsh-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index b8fc8d7..592b81f 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -1000,7 +1000,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED)

         for (i = 0; i < npoolTypes; i++) {
             if ((poolType = virStoragePoolTypeFromString(poolTypes[i])) < 0) {
-                vshError(ctl, "%s", _("Invalid pool type"));
+                vshError(ctl, _("Invalid pool type '%s'"), poolTypes[i]);
                 virStringFreeList(poolTypes);
                 return false;
             }
-- 
1.8.3.2




More information about the libvir-list mailing list