[libvirt] [PATCH] migration: do not restore labels on failed migration

[Daniel P. Berrange]

On Tue, Aug 20, 2013 at 05:10:38PM -0600, Eric Blake wrote:
> The problem at hand is that when migrating between different
> configurations, the destination first attempts to label files before
> even starting qemu - and does a chown() to root:root. 

IMHO making libvirt work in the face of such admin mis-configurations
is out of scope.

> We should really consider whether we need more framework for diagnosing
> incompatible configurations between source and destination, and outright
> rejecting migration where two machines do not share the same user/group
> setup.

I tend to view this as a general OS management problem. Tools like
puppet/chef/etc should be used to manage your virt hosts to avoid
inconsistent configs between hosts.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|