[libvirt] [PATCHv2 2/2] virBitmapParse: Don't shadow errors
Daniel P. Berrange
berrange at redhat.com
Wed Aug 21 13:01:06 UTC 2013
On Tue, Aug 20, 2013 at 11:33:44AM +0200, Peter Krempa wrote:
> A few of the callers of virBitmapParse shadow the returned error.
> ---
>
> Notes:
> I'm kind of worried that we are making some error messages
> worse compared to what they were before. If you don't like
> the way this will turn out, I'll prepare a inverse fix
> where all callers will be fixed to report proper errors
> and virBitmapParse will remain silent.
>
> src/conf/domain_conf.c | 5 +----
> src/conf/network_conf.c | 3 ---
> src/nodeinfo.c | 5 +----
> src/qemu/qemu_driver.c | 2 --
> src/xenxs/xen_sxpr.c | 5 +----
> tests/cpuset | 2 +-
> 6 files changed, 4 insertions(+), 18 deletions(-)
This should really be squashed into the previous patch, so that we're
not introducing a bug in one patch & removing it in a separate patch
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list