[libvirt] [PATCH] Set security label on FD for virDomainOpenGraphics

Daniel P. Berrange berrange at redhat.com
Thu Aug 22 11:54:14 UTC 2013


On Thu, Aug 22, 2013 at 01:52:17PM +0200, Michal Privoznik wrote:
> On 22.08.2013 13:39, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange at redhat.com>
> > 
> > The virDomainOpenGraphics method accepts a UNIX socket FD from
> > the client app. It must set the label on this FD otherwise QEMU
> > will be prevented from receiving it with recvmsg.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> 
> (*)

> * Side note - I've noticed more and more signed-off patches. Does this
> mean we are seamlessly moving to make it a standard?

I do it as a matter of habit on everything I commit these days to any
project I'm involved in.

If people think we should make it mandatory for libvirt, I'd be supportive
of that, but I don't feel strongly enough to force the issue myself right
now.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list